Offline Mode - UART and GPS #787
Conversation
…bitbang it clean up max 7 clang
|
@tyeth This pull request is ready for review. Please note that the areas of note are within |
| msg_uart_add.cfg_serial.use_sw_serial = component["useSwSerial"] | false; | ||
| msg_uart_add.cfg_serial.sw_serial_invert = | ||
| component["swSerialInvert"] | false; |
There was a problem hiding this comment.
These should eventually be added to the offline config tool for export.
To be fair the use_sw_serial thing is a board/device specific setting which the firmware knows, and swSerialInvert too perhaps? So the defaults of false may be incorrect or want to be #if HAS_SW_SERIAL guarded
There was a problem hiding this comment.
Added guard around these funcs.
There was a problem hiding this comment.
Should the false default value for useSwSerial be true if HAS_SW_SERIAL=1 ?
There was a problem hiding this comment.
I do not think so?
If the "useSwSerial" in JSON is set to true, it sets msg_uart_add.cfg_serial.use_sw_serial = true, otherwise false
This pull request brings UART and GPS modules into WipperSnapper's offline mode and the upcoming v2 (online) firmware.
Since these two components are completely rewritten for the WipperSnapper API-v2, they are not yet ready to be added to WipperSnapper Online until the IO Production broker supports WipperSnapper API v2.
UART (v2 refactor) 🔧 - UART has been fully refactored and rebuilt to support components other than the PM25 AQ Sensor. The UART component architecture is similar to the i2c component and provides a general driver base class (drvBase) for creating a new UART driver.
GPS 🛰️ - GPS functionality has been added to WipperSnapper! This is a new feature ✨
Resolves:
#360
#727
#755
#753